Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax constraint for Signal.constant #3032

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

armanbilge
Copy link
Member

No description provided.

Copy link
Collaborator

@SystemFw SystemFw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit unsure if this is of any value. The Concurrent constraint is everywhere in fs2, and I don't see the difference between Spawn and Concurrent to be that meaningful for users. I can see how Temporal vs Concurrent might help, but not really this one. Open to changing my mind ofc

@armanbilge
Copy link
Member Author

FWIW I completely agree, I doubt this would make a difference for anyone. Certainly not to me.

Was this Concurrent by mistake, or intentional? Or maybe it's intentional now? e.g.. if we don't merge this should I open an issue so we remember to fix this in FS2 4 or something 😂

@diesalbla
Copy link
Contributor

@armanbilge If you fix PR, happy to merge it if you still think it of use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants